Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for for changes in Nerdfont version 3.x #417

Closed
cstrahan opened this issue Jul 15, 2023 · 5 comments
Closed

Update for for changes in Nerdfont version 3.x #417

cstrahan opened this issue Jul 15, 2023 · 5 comments

Comments

@cstrahan
Copy link

cstrahan commented Jul 15, 2023

Nerdfont v3.x introduced some backwards incompatible changes (they moved some code-points around, etc).

See:

Also, a recent wezterm release (20230712-072601-f4abf8fd) bumped its bundled Nerdfont fallback to v3.0.1, so people depending on wezterm to provide the icon glyphs will have their lvim icons not render correctly.

And, of course, this will also apply to both wezterm and non-wezterm users who install the latest Nerdfont patched fonts.

@LostNeophyte
Copy link
Member

LostNeophyte commented Jul 15, 2023

yea, we already took care of it, did we miss something? also this is a repo for the website, did you mean to make the issue in lunarvim/lunarvim?

@cstrahan
Copy link
Author

cstrahan commented Jul 15, 2023

Files that fail nerdfix:

(EDIT: fixed the regex)

~/.local/share/lunarvim
% nerdfix check --recursive . 2>&1 | rg './site/pack/lazy/opt/(.*?)/.*:.*:' -or '- [ ] $1' | sort -u
- [ ] alpha-nvim
- [ ] bufferline.nvim
- [ ] lualine.nvim
- [ ] nvim-navic
- [ ] nvim-tree.lua

nerdfix will provide suggestions for to partially automate replacing old symbols.

We should probably ping these plugins' maintainers, and link back here.


Also, FWIW, I just installed LunarVim today via

LV_BRANCH='release-1.3/neovim-0.9' bash <(curl -s https://raw.githubusercontent.com/LunarVim/LunarVim/release-1.3/neovim-0.9/utils/installer/install.sh)

@cstrahan
Copy link
Author

cstrahan commented Jul 15, 2023

Plugins to notify/fix:


lualine

As of latest (nvim-lualine/lualine.nvim@05d78e9), still has an obsolete symbol, but only in a spec:

~/src/nvim_plugins/lualine.nvim
% nerdfix check --recursive . 2>/dev/null
note: Found obsolete icon U+F718
    ┌─ ./tests/spec/lualine_spec.lua:735:14
    │
735 │         |{1:  a.txt }
    │              ^ Icon 'mdi-file_document' is marked as obsolete
    │
    = You could replace it with:
          1. 󰈙 U+F0219 md-file_document
          2. 󰷈 U+F0DC8 md-file_document_edit
          3. 󱪗 U+F1A97 md-file_document_alert
          4. 󱪝 U+F1A9D md-file_document_plus

@cstrahan
Copy link
Author

What prompted this issue was me thinking the snippet symbol in use was deprecated (I thought it was rendering wrong), but I was mistaken.

Icon: 
Class: nf-cod-symbol_snippet
UTF: \ueb66

@cstrahan
Copy link
Author

yea, we already took care of it, did we miss something? also this is a repo for the website, did you mean to make the issue in lunarvim/lunarvim?

Oops - yes. And I didn't see your message until now (after refreshing browser tab).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants