Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): match new Nerd Fonts 3.0.0 release #114

Merged
merged 1 commit into from
May 9, 2023

Conversation

XenoPhex
Copy link
Contributor

@XenoPhex XenoPhex commented May 3, 2023

@XenoPhex XenoPhex changed the title fix(icons): to match new NerdFonts 3.0.0 release fix(icons): match new Nerd Fonts 3.0.0 release May 3, 2023
@tylerw
Copy link

tylerw commented May 3, 2023

See also #104

@mhanberg
Copy link
Contributor

mhanberg commented May 4, 2023

This branches fixes the broken icons for me. My JetBrainsMonoNerdFonts updated the other day and they've been broken ever since.

@XenoPhex
Copy link
Contributor Author

XenoPhex commented May 4, 2023

For those looking for a fuller list of icons that popular tools are using, feel free to use mine - I updated it recently to utilize the 3.0.0 release: https://github.com/XenoPhex/nvim/blob/42192ef0c637c3ae6e274df4b7b2df633577a72c/lua/utils/icons.lua#L43-L160

@SmiteshP
Copy link
Owner

SmiteshP commented May 7, 2023

Is it just me or are these newer replacement icons very tiny in comparison to older ones?

@tylerw
Copy link

tylerw commented May 8, 2023

Using this branch, the replacements seem normal sized to me:
Screen Shot 2023-05-08 at 1 50 33 PM

Using kitty v0.28.1, FiraCode Nerd Font Mono Retina (Nerd font v3.0.0), Neovim v0.10.0-dev-295+g01f81ed89.

Copy link
Owner

@SmiteshP SmiteshP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks! :)

@SmiteshP SmiteshP merged commit 15704c6 into SmiteshP:master May 9, 2023
@XenoPhex XenoPhex deleted the fix-icons branch May 15, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants