Add a Type definition for uiType used in the text-editor #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3293/ |
hannahu
reviewed
Nov 11, 2024
src/components/text-editor/types.ts
Outdated
| @@ -7,3 +7,5 @@ import { CustomElementDefinition } from '../../global/shared-types/custom-elemen | |||
| export type TextEditorPlugin = { | |||
| node: CustomElementDefinition[]; | |||
| }; | |||
|
|
|||
| export type EditorUiTypes = 'standard' | 'minimal'; | |||
There was a problem hiding this comment.
Singular
Suggested change
| export type EditorUiTypes = 'standard' | 'minimal'; | |
| export type EditorUiType = 'standard' | 'minimal'; |
john-traas
force-pushed
the
add-ui-types-as-a-type
branch
2 times, most recently
from
e18c3f8
to
c65260e
Compare
jgroth
reviewed
Nov 12, 2024
| @@ -7,3 +7,5 @@ import { CustomElementDefinition } from '../../global/shared-types/custom-elemen | |||
| export type TextEditorPlugin = { | |||
| node: CustomElementDefinition[]; | |||
| }; | |||
|
|
|||
| export type EditorUiType = 'standard' | 'minimal'; | |||
There was a problem hiding this comment.
There's a missing release tag on this type
john-traas
force-pushed
the
add-ui-types-as-a-type
branch
from
71ac81e
to
6b070d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Lundalogik/crm-feature/issues/4455
May need separate PR's in both building blocks and lime-crm-components to then import and use the Type definition.