Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links/Markdown in headings #151

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Fix links/Markdown in headings #151

merged 5 commits into from
Jun 14, 2024

Conversation

asinghvi17
Copy link
Collaborator

Try to fix Markdown heading rendering, by only rendering the anchor string if it's equivalent to the rendered text. Not quite there yet...

@asinghvi17
Copy link
Collaborator Author

asinghvi17 commented Jun 1, 2024

@avik-pal this might fix the issue you've been having in Lux!

@asinghvi17 asinghvi17 marked this pull request as ready for review June 12, 2024 00:53
@asinghvi17
Copy link
Collaborator Author

asinghvi17 commented Jun 12, 2024

Will merge tomorrow afternoon if no comments! This works on a local sweat test.

@avik-pal
Copy link
Member

Missed this. Let me trigger a build with this branch

avik-pal added a commit to LuxDL/Lux.jl that referenced this pull request Jun 12, 2024
@avik-pal
Copy link
Member

You can go ahead with this, for some reason the documentation CI in Lux is not correctly installing the Manifest.

@asinghvi17 asinghvi17 merged commit 21f7059 into master Jun 14, 2024
2 checks passed
@asinghvi17 asinghvi17 deleted the as/betterlink branch June 14, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants