-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to redirect trailing slash urls #74
Open
LilithHafner
wants to merge
17
commits into
LuxDL:master
Choose a base branch
from
LilithHafner:lh/redirect-slash
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
706ea3f
iniital untested implementation
LilithHafner d52fe0b
add superficial tests
LilithHafner 476cdd1
print
LilithHafner 3708e9f
deug
LilithHafner ece1e31
rel url to avoid needing knowledge that we only have at deploy-time
LilithHafner 4f52871
keep fragments
LilithHafner 7ea54c5
remove stray tags
LilithHafner 3465bb6
update info
LilithHafner 243b2b7
don't serve comment
LilithHafner 8d49234
mini-minify
LilithHafner e9ba132
add fallbacks (probably broken)
LilithHafner a7f511c
give js 1 second to perform the refresh before fallback
LilithHafner cb77856
Revert "give js 1 second to perform the refresh before fallback"
LilithHafner 40cee84
more comment
LilithHafner da746fe
Merge branch 'master' into lh/redirect-slash
asinghvi17 0849ac0
Update Test compat to 1
asinghvi17 4d6ddaa
Merge branch 'master' into lh/redirect-slash
LilithHafner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have access to the deploy URL through
settings.deploy_url
anddeploy_decision
, so in that situation we could add that in if it's better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A recall trying that and finding that field to be empty.