Simple Github Action and RPath fix on Linux #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome. merged |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just tried out Newton on Linux and ran into a small linker problem.
Essentially, I could not link my app to the installed Newton libraries, ie the
ones created by
make install(the ones in the build folder work fine).The problem was due to some missing RPath settings in CMakeLists.txt
which this PR addresses.
The PR also adds a simple GitHub Action to build Newton as well as a minimal
Hello World program. The Hello World app is just a stripped down but standalone
version of ndTest to ensure everything works as intended on Linux.
The GitHub Action should also provide instant feedback from now on whenever the
Linux build breaks for any reason.
I hope you find this useful.