Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests in CI for Windows. #299

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

olitheolix
Copy link
Contributor

Automatically build and run the test suite in the Windows runners as well.

I suggest to leave this PR open until the Linux build works again. I can then
rebase it to the latest version and verify it works on both platforms.

@JulioJerez
Copy link
Contributor

JulioJerez commented Oct 14, 2022

ok I now fixed the build errors in Linux.
I will wait until the automatic build complete the test.
we now have to see, what to do to make the windows build not to fail building the test.

are you saying to hold on this pull request?

@olitheolix
Copy link
Contributor Author

I just rebased the branch onto the latest master and now all tests are green on both platforms. You can merge the PR now if you want.

At this point, CI is building and testing Newton on both Windows and Linux 🎉

@JulioJerez JulioJerez merged commit 44ccf37 into MADEAPPS:master Oct 14, 2022
@JulioJerez
Copy link
Contributor

alright, it is merged

@JulioJerez
Copy link
Contributor

The code do compile in my computer but fail when the automatic build is run.
I fail in both Linux and windows.
I do not why, because the bug report does not say where.

@JulioJerez
Copy link
Contributor

oh I see it is a runtime error.

The error was produced by me setting the matrix posit.m_w to 1 because I got the assert.
but I fixed in the wrong place.

This goes to you question about helper functions. which I will answer later.
anyway, it should be fine now,
This is really cool.

@olitheolix olitheolix deleted the run-tests-on-windows branch October 15, 2022 01:39
@JulioJerez
Copy link
Contributor

ok, I think I finally have it building for both Window and Linux
on the test demos and some of the thier part libraries for Linux I could not find the warning level option.
so I just added
if (MSVC)
target_compile_options(${PROJECT_NAME} PRIVATE "/W4")
endif()

you had /wall which seems to work for both widow a linux. but in windows the third-party libraries are full of warning
and polluted the the output windows with ton of pedante message, so I use /w4

I fixed all the warning for Newton and the lib that newton uses so it compiles fine with the /Wall option.

Now we can move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants