Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Fixes #80

Closed
wants to merge 17 commits into from
Closed

General Fixes #80

wants to merge 17 commits into from

Conversation

tk2217
Copy link
Member

@tk2217 tk2217 commented Mar 27, 2022

This pull request includes a LOT of refactoring, mainly moved from #73 but without the slash command related changes.

List of Changes

  • Refactor the samquote command extensively.
  • General refactoring of other commands.
  • Slight refactoring of the command system.
  • Move permission roles to the config. (More info on this below.)
  • A bit of renaming and moving stuff into packages.
  • Remove EndlessStringArgument as GreedyStringArgument (formerly MessageArgument) was identical.
  • Chanegd DiscordUserAgument to a more generic DiscordMentionArgument to allow for use with roles and channels.
  • Move mose things to nio. (Namely ExternalFiles.)

Updating

Config Changes

The following entries have been added to the config. (This can be copy-pasted into an existing config file.)

{
    "graph_channel": 736019542882517062,
    "srhelper_chat_channel": 467729470539694091,
    "permission_roles": {
        "BOT_DEVELOPER": 589238520145510400,
        "DEVELOPER": 519740942861860874,
        "ADMINISTRATOR": 180794313494495233,
        "MODERATION": 180794061429538816,
        "SR_HELPER": 299109861696995329,
        "SUPPORT": 180794530398732288,
        "RETIRED_SUPPORT": 235159617108181003,
        "USER": 349434193517740033
    }
}

Other

  • I'd be happy to fix any bugs arising from these changes even after a merge.

@tk2217 tk2217 marked this pull request as draft March 27, 2022 18:56
@tk2217
Copy link
Member Author

tk2217 commented Mar 27, 2022

Still working on adding fixes for #76.

@tk2217
Copy link
Member Author

tk2217 commented Mar 31, 2022

The current blocker on this is rendering the emojis for ranks so I can update the SrHelper one.

@tk2217
Copy link
Member Author

tk2217 commented Apr 15, 2022

Rank emotes have been rendered and uploaded to a private server but are now referenced in raw mention format meaning that they will still appear correctly if deleted or changed. The new emojis are shown below.

image

@tk2217
Copy link
Member Author

tk2217 commented Apr 16, 2022

Note: The AbstractChannelModificationCommand class is the start of a command Refriz asked me to make.
Edit: Scrapped for now.

@tk2217 tk2217 changed the title General Fixes (Cherry Pick of #73) General Fixes Jun 13, 2022
@tk2217
Copy link
Member Author

tk2217 commented Jun 14, 2022

We may also want to consider having the ?imagedump command link out to Owen's repo so we don't have to make the zip ourselves. In addition, it might be a good idea to move over to the mariadb connector from the mysql one.

@tk2217 tk2217 marked this pull request as ready for review June 14, 2022 22:21
@tk2217
Copy link
Member Author

tk2217 commented Jun 16, 2022

Edit: Wrong pr.

@tk2217
Copy link
Member Author

tk2217 commented Oct 2, 2022

I'm going to close this for now since it's become somewhat of a world plots moment but some stuff will probably make it into some smaller prs.

@tk2217 tk2217 closed this Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant