Fixed okwarning block warning #389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMeli
reviewed
Oct 14, 2024
Comment on lines
+18
to
+30
| import warnings | ||
|
|
||
| warnings.filterwarnings( | ||
| "ignore", | ||
| message="DCDReader currently makes independent timesteps", | ||
| category=DeprecationWarning, | ||
| module="MDAnalysis.coordinates.DCD", | ||
| ) | ||
|
|
||
| import MDAnalysis as mda | ||
|
|
||
| MDAnalysis_version = mda.__version__ | ||
|
|
There was a problem hiding this comment.
Can you please explain why this is necessary, wasn't the :okwarning: below enough?
There was a problem hiding this comment.
So this part addresses the warning -
/home/runner/micromamba/envs/mda-user-guide/lib/python3.10/site-packages/MDAnalysis/coordinates/DCD.py:165: DeprecationWarning: DCDReader currently makes independent timesteps by copying self.ts while other readers update self.ts inplace. This behavior will be changed in 3.0 to be the same as other readers. Read more at https://github.com/MDAnalysis/mdanalysis/issues/3889 to learn if this change in behavior might affect you.
warnings.warn("DCDReader currently makes independent timesteps"
For solving this warning changing conf.py file was needed.
Adding :okwarning: helped to solve the other warning related to it.
This reverts commit 9b5b3e8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed okwarning block warning
Ignored
DCDReader currently makes independent timestepswarning.Closes - #378
📚 Documentation preview 📚: https://mdanalysisuserguide--389.org.readthedocs.build/en/389/