-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI #1883
Comments
#386 has the develop docs being built on each commit to develop, are you talking about preparing the docs as part of each PR? |
I think @tylerjereddy is referring that we can see the rendering of the docs on each PR. This will help to ensure that docs are rendered correctly before we merge and ease developer time because we don't have to build the documentation pages manually on our machines. |
Yeah I think we could set that up off travis if need be, we would just need
a place to host them once built. Would circle ci do the hosting too?
…On Sun, May 6, 2018 at 12:33 PM, Max Linke ***@***.***> wrote:
I think @tylerjereddy <https://github.com/tylerjereddy> is referring that
we can see the rendering of the docs on each PR. This will help to ensure
that docs are rendered correctly before we merge and ease developer time
because we don't have to build the documentation pages manually on our
machines.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1883 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI0jBx93hhvjzSz06-BDNOABXkgSZZOvks5tvyXegaJpZM4TwNl9>
.
|
Yes, Circle CI hosts the artifacts |
It may be worth considering addition of CircleCI to our test matrix?
It is starting to become pretty common for building project documentation and storing the artifact html pages for visual inspection to facilitate i.e., expansion / correction of docs.
I'm even seeing some efforts to run
--quick
asv benchmarks in CircleCI when benchmark code has been changed just to make sure it executes / is not broken by changes.The text was updated successfully, but these errors were encountered: