Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs in timestep.pyx #4719

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix docs in timestep.pyx #4719

merged 1 commit into from
Sep 27, 2024

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Sep 26, 2024

Changes made in this Pull Request:

  • changed outdated reference of AtomGroup.coordinates() to AtomGroup.positions
  • changed outdated reference of AtomGroup.velocities() to AtomGroup.velocities
  • minor doc fixes

PR Checklist

  • n/a Tests?
  • Docs?
  • n/a CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4719.org.readthedocs.build/en/4719/

- changed outdated reference of AtomGroup.coordinates() to AtomGroup.positions
- changed outdated reference of AtomGroup.velocities() to AtomGroup.velocities
- minor doc fixes
Copy link

Linter Bot Results:

Hi @orbeckst! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (8939b3e) to head (ffd1504).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4719      +/-   ##
===========================================
- Coverage    93.54%   93.53%   -0.02%     
===========================================
  Files          173      185      +12     
  Lines        21439    22505    +1066     
  Branches      3983     3983              
===========================================
+ Hits         20056    21049     +993     
- Misses         929     1002      +73     
  Partials       454      454              
Flag Coverage Δ
93.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looks good, thanks @orbeckst

@RMeli RMeli merged commit b7f91a5 into develop Sep 27, 2024
24 of 25 checks passed
RMeli pushed a commit to RMeli/mdanalysis that referenced this pull request Oct 3, 2024
- changed outdated reference of AtomGroup.coordinates() to AtomGroup.positions
- changed outdated reference of AtomGroup.velocities() to AtomGroup.velocities
- minor doc fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants