-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Coerce images to 32-bit #759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes you've made look good to me. I have one question/recommendation, but I was also thinking maybe we should have something in the outputs
page about the change in datatypes?
Codecov Report
@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 92.83% 92.85% +0.01%
==========================================
Files 27 27
Lines 2192 2197 +5
==========================================
+ Hits 2035 2040 +5
Misses 157 157
Continue to review full report at Codecov.
|
Hm, I'm not sure what we'd put in the outputs page. This change should be relatively invisible aside from freer disks 🙂. Programs should read everything correctly, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. I guess not many people will care. Approving!
Closes #757 .
Changes proposed in this pull request:
io.save_img
docstring