-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
地下埋設物を対象とした平面直角座標系への対応 #640
Merged
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f2272c6
ファイル名からEPSGコードを取得 (変換なし)
TadaTeruki caf7ad7
transformの具体的な処理の関数化
TadaTeruki 143fd8b
変換処理の実装
TadaTeruki 7dcbcf4
平面直角座標系の変換方法を変更
TadaTeruki f9d5e3e
fmt
TadaTeruki 28cb672
不要なログを削除
TadaTeruki 3a66f03
変換処理の修正
TadaTeruki aa0c909
EPSGコードの取得方法をXMLのattributesから取得
TadaTeruki d2a396c
obj_writerのlint
TadaTeruki e775429
lint/fmt
TadaTeruki 4acdebe
EPSGコードをgml:Envelopeから入力
TadaTeruki 911a97a
resolve conflict
TadaTeruki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q)質問でした!
parse_geometry_prop
メソッドを修正しているということは、gml:boudedBy.gml:Envelop
のsrsName
を取得して一括で座標系を適用させる、ということではなく、全ての個別地物の座標系を取得して個別に適用させている、という認識で良いでしょうか?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gml: Envelope
のsrsName
は、全体というよりも、Envelopeそのものの空間参照系を指すattributionという認識でした。意味的には地物単体から取得するのが合理的と考えているのですが、いかがでしょうか...?https://www.mlit.go.jp/plateaudocument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(なおデータのミスから各地物でepsgが間違っている・そもそも指定されていないものがある、という点も考慮が必要そうです。判断をお任せしてよろしいでしょうか。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TadaTeruki 同じく地物単体から座標系を取得し、個別に適用するのが合理的と思っています!
今でも、全ての地物に対して個別にtransformをかけているので、パフォーマンスにもさほど影響はないはずですし…
その上で、以下の点を考慮する必要がありますね。
これでいきましょうか!