logic to set debug styling of the GUI is incorrect

[Wachizungu]

Work environment

Questions	Answers
Type of issue	Bug
OS version (server)	Ubuntu
OS version (client)	N/A
PHP version	7.2
MISP version / git hash	2.4.139, 7431bee
Browser	N/A

Expected behavior

setting debug to 'Debug on' leads to setting debugOn class for certain GUI elements.

Actual behavior

setting debug to 'Debug on' leads to setting debugOff class for certain GUI elements.

Steps to reproduce the behavior

Set setting debug to Debug on. Inspect element on footer, check the classes assigned to the footer div. It will be "footer debugOff".

Notes

I don't really understand why this difference in classes is there so didn't want to push a potential fix myself without asking input. Many different view pages have conditional formatting based on $debugMode (footer is one of them).

Three options for debug setting are:
Debug off -> 0
Debug on -> 1
Debug + SQL dump -> 2

Culprit line / function seems to be:
https://github.com/MISP/MISP/blob/2.4/app/Controller/AppController.php#L789
Should be (Configure::read('debug') >= 1) instead of (Configure::read('debug') > 1) I think.

If for some reason the conditional formatting should only be done for Debug + SQL dump then this issue can just be closed and I'll document it somewhere.

[iglocska]

Ok that was actually mostly correct - the reason being that debug = 2 alters the layout of the page by inserting the SQL dump.

[Wachizungu]

Okay, thanks for the follow up. Can change it back if better that way, maybe adding a comment.

[iglocska]

It depends - did you see any issues that got fixed with the change? Maybe we need to separate out the logic of changing the layout vs some other changes.

[Wachizungu]

No, when I spotted this I was actually trying to debug the shortcuts / keybinds popup, which is hidden with debug on, leading to me trying to find out why / how it gets set and me finding it strange it only got set for debug = 2.

There is some styling that depends on debugOff, I didn't immediately understand what it was doing which is why I opened this issue and asked if this sounded like a bug on gitter. Looking back at it a bit, unless I'm missing something the differences are mostly minor (except for the footer part for SQL dump).

[iglocska]

I think the main difference used to be a relative vs absolute offset causing the old style flash messages to be inserted straight into the menu - the debugOn mode used to add a 50px offset to address this. No longer relevant with the modern flash messages.