Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Redis over TLS #49

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Allow Redis over TLS #49

merged 2 commits into from
Apr 22, 2024

Conversation

christianmg99
Copy link
Contributor

What does it do?

It fixes #47 by prepending tcp:// only when not present in $REDIS_FQDN already.

@ostefano
Copy link
Collaborator

@christianmg99 is tls://redis.example.com handled correctly by MISP itself? In other words, what about configure_misp.sh? Did you try building the image and looking at diagnostics?

@ostefano ostefano self-requested a review April 20, 2024 18:44
@ostefano ostefano added the enhancement New feature or request label Apr 20, 2024
Copy link
Collaborator

@ostefano ostefano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. We need to make sure that tls:// prefixed strings are correctly managed by MISP itself.

@christianmg99
Copy link
Contributor Author

By the time I found the replacement was in the entrypoint I had already read all Misp code regarding redis_host, and all I saw was mindful about the variable starting with tls:// such as in zmq plugin and in PHP-redis plugin, I also looked into cakePHP and it has url prefix parsers as well. I currently use it like that in a custom deployment and it works fine.

@christianmg99
Copy link
Contributor Author

Anyways, as it is coded, you would need to prepend tls:// anyways for it to be used, so it's only for the ones who want to "force" tls use in the variable like me that will take place, everyone else will follow the standard tcp:// prepend.

@ostefano ostefano merged commit b8d722a into MISP:master Apr 22, 2024
1 check passed
dgujarathi pushed a commit to dgujarathi/misp-docker that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis over TLS incompatible due to hardcoded tcp:// in entrypoint
2 participants