-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Redis over TLS #49
Conversation
@christianmg99 is tls://redis.example.com handled correctly by MISP itself? In other words, what about configure_misp.sh? Did you try building the image and looking at diagnostics? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment. We need to make sure that tls://
prefixed strings are correctly managed by MISP itself.
By the time I found the replacement was in the entrypoint I had already read all Misp code regarding redis_host, and all I saw was mindful about the variable starting with tls:// such as in zmq plugin and in PHP-redis plugin, I also looked into cakePHP and it has url prefix parsers as well. I currently use it like that in a custom deployment and it works fine. |
Anyways, as it is coded, you would need to prepend tls:// anyways for it to be used, so it's only for the ones who want to "force" tls use in the variable like me that will take place, everyone else will follow the standard tcp:// prepend. |
What does it do?
It fixes #47 by prepending
tcp://
only when not present in$REDIS_FQDN
already.