Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies for NumPy 2 compatibility #511

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Oct 23, 2024

All tests pass and demo.ipynb works without any errors or warnings using NumPy >= 2.

@cbrnr cbrnr marked this pull request as draft October 23, 2024 08:09
@cbrnr
Copy link
Contributor Author

cbrnr commented Oct 23, 2024

OK, I'm struggling a bit with dependencies here. If you want to keep Python >= 3.9 and at the same time also support 3.13, scipy >= 1.13.1 works only for Python <= 3.12. Strangely, uv does not use scipy 1.14.1 (there is no binary wheel for scipy 1.13.1 for Python 3.13) for Python 3.13, but insists on using 1.13.1...

@bemoody
Copy link
Collaborator

bemoody commented Oct 24, 2024

Sure, seems like the problem is that "uv run --extra dev pytest" is doing something bizarre.

I don't know exactly what that command is doing or trying to do, but it seems to be trying to install the oldest versions of packages that satisfy our dependencies. That is not what we want (that's not what any normal user does) and is not likely to lead to a good solution.

@cbrnr
Copy link
Contributor Author

cbrnr commented Oct 24, 2024

It might actually be something at the core of how uv resolves dependencies, yes. I've opened an issue here: astral-sh/uv#8492

@YmirKhang
Copy link

Hells yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants