Skip to content

Commit

Permalink
Fix race with hot-reloader-client clearing overlay errors (vercel#71771)
Browse files Browse the repository at this point in the history
This `resolvePendingHotUpdate` in the `SERVER_COMPONENT_CHANGES` event
seems to be causing a race where an error would come through in a fast
refresh response and then the overlay would be cleared.

I'm not really sure why we were resolving a pending hot update here
because we already call it on `handleSuccessfulHotUpdateWebpack` and
`tryApplyUpdate` but I'm consistently seeing correct behavior without
this.
  • Loading branch information
ztanner authored Oct 25, 2024
1 parent 38c3e83 commit 29038fc
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,6 @@ function processMessage(
reloading = true
return window.location.reload()
}
resolvePendingHotUpdateWebpack()
startTransition(() => {
router.hmrRefresh()
dispatcher.onRefresh()
Expand Down

0 comments on commit 29038fc

Please sign in to comment.