Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picker alt text #723

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

dphiffer
Copy link
Member

@dphiffer dphiffer commented Jul 13, 2023

Note: this is branched from python3-upgrade but I can redo it against master if the Python upgrade isn't going to land any time soon.

Overview

This adds an interface for specifying alt text from the "picker" template, used by browser extensions and bookmarklets to upload to the site. The tabbed interface is modeled on the one from Settings. Fixes #719.

See also: MLTSHP/mltshp-patterns#1039

Screenshots

New post interface showing title field, and a tabbed interface where the Description tab is selected and Alt Text tab is not selected, a textarea field is below with the text 'source: https://example.com'. A piggy bank Save This button is below. New post interface showing title field, and a tabbed interface where the Alt Text tab is selected and Description tab is not selected, a textarea field is below with the text 'alt text goes here'. A piggy bank Save This button is below.

@jessamynwest jessamynwest merged commit f01ee78 into MLTSHP:python3-upgrade Jul 13, 2023
@bradchoate
Copy link
Collaborator

Yes, if you don't mind, please create a separate PR for master. I don't know when the Python 3 update will happen. Still have more testing to do.

@dphiffer dphiffer mentioned this pull request Jul 13, 2023
@dphiffer dphiffer deleted the picker-alt-text branch July 14, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants