Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed type of ICustomer.multipass_identifier #654

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

natewaddoups
Copy link
Contributor

I suspect that "multipass_identifier: null" was never the intent...

@natewaddoups
Copy link
Contributor Author

natewaddoups commented Jun 27, 2024

There's a bigger problem here - the createCustomer mutation expects an object with camelCased properties, but the shopify-api-node library requires an object with snake_cased properties.

Reopening the PR because the createCustomer mutation works with both snake_case and camelCase, so the existing property names are just fine.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 2dec9b8 on natewaddoups:master
into fd6d034 on MONEI:master.

@lpinca lpinca merged commit 6b7aad4 into MONEI:master Jun 30, 2024
9 checks passed
@lpinca
Copy link
Collaborator

lpinca commented Jun 30, 2024

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants