Fixes to transect extraction and plotting #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, when a segment of a transect ends exactly at an intersection with a cell edge, there are redundant intersection points in the list. This merge removes those redundant points. This merge also fixes some index arrays that were previously type float but should be int.
This merge fixes masking of the SSH to ignore cells where maxLevelCell=0
TestingI used this branch along with https://github.com/xylar/polaris/tree/add-isomip-plus-init to produce the following transect plots. Without these fixes, the plot could not be produced. Without the SSH fix, transects include a jump to SSH = 0 in the region of grounded ice.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge fixes several issues with transects:
maxLevelCell==0