Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file names on LCRC server #767

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

trhille
Copy link
Collaborator

@trhille trhille commented Jan 31, 2024

Update file names on LCRC server to use files that do not have negative basal heat flux.

Note: The Antarctic data files still include NaNs as missing values. This requires the changes in MPAS-Dev/MPAS-Tools#551 to pass.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

Update file names on LCRC server to use files that do not have
negative basal heat flux.
@matthewhoffman
Copy link
Member

Testing

I ran the koge bugt mesh gen case (93) and it ran successfully. I had not update MPAS-Tools to include MPAS-Dev/MPAS-Tools#551 but because there are no negatives in the basalHeatFlux field, there was no problem.

@matthewhoffman
Copy link
Member

Testing, part 2

Realized I could test all the mesh gen tests that are affected at once with a custom suite (compass setup -n 0 43 44 92 93 99), and that would be the more robust test. This time it also includes MPAS-Dev/MPAS-Tools#551 (which as said in previous comment won't actually be needed).

Test Runtimes:
11:44 PASS landice_antarctica_mesh_gen
08:28 PASS landice_greenland_mesh_gen
07:30 PASS landice_humboldt_mesh_gen
00:31 PASS landice_kangerlussuaq_mesh_gen
00:46 PASS landice_koge_bugt_s_mesh_gen
05:32 PASS landice_thwaites_mesh_gen
Total runtime 34:31
PASS: All passed successfully!

@trhille
Copy link
Collaborator Author

trhille commented Jan 31, 2024

which as said in previous comment won't actually be needed

@matthewhoffman, MPAS-Dev/MPAS-Tools#551 is needed for the Antarctic meshes, because that data file contains NaNs. The Greenland one does not, so those should pass without the MPAS-Tools branch.

@matthewhoffman
Copy link
Member

Ah, thanks, I missed that distinction, but I see you indicated that in the description

@matthewhoffman matthewhoffman merged commit 84d8882 into MPAS-Dev:main Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants