Add conservative remapping of observational datasets onto Greenland Ice Sheet mesh #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add conservative remapping directly from GrIS datasets for bed, thickness, velocities, and uncertainties.
Add forward slash after data_path in case path is defined incorrectly, i.e., in case user forgets to finish path with forward slash.
Run E3SM_RegridWeightGen on single processor instead of using srun and multiple nodes. srun was causing cryptic errors, usually claiming to be out-of-memory errors, but the 3-30km mesh creation worked fine on one processor. 1-10km case has not yet been tested, and may require the issue with srun to be resolved. Also do not create new scrip files for datasets if they already exist in the data directory.
Take care of large negative dHdt value in a few cells and make sure dHdt uncertainty is positive
Also add back ESMF_RegridWeightGen on multiple procs.
Change data path to default to Perlmutter rather than Chicoma. Fix file names to reflect updated gridded data set at LCRC. Make changes required by linter.
|
@andrewdnolan, as of 62155ab, this runs successfully on one compute node on Perlmutter in ~11.5 minutes. We ultimately want this to follow generally the same workflow as the |
Testing
Command run: where [mesh]
levels = 20
min_spac = 6.e3
max_spac = 60.e3
[parallel]
account = m4288
[job]
qos=debug
wall_time = 0:30:00Results: |
andrewdnolan
reviewed
Apr 3, 2024
andrewdnolan
approved these changes
Apr 3, 2024
5 tasks
Add explanation of GrIS data interpolation to users guide. Also update the path to data sets in the Antarctica users guide.
Update developers guide to explain data interpolation in Greenland mesh_gen test case.
matthewhoffman
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds conservative remapping of observational data sets (thickness, bed topography, velocity, and uncertainties) onto the Greenland Ice Sheet mesh, and handles some of the peculiarities of the other gridded datasets (unit conversions, sign conventions, etc).
Checklist
Testingin this PR) any testing that was used to verify the changes