Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the namelist option for tidal velocity #826

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Update the namelist option for tidal velocity #826

merged 1 commit into from
Jun 4, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jun 4, 2024 •
edited
Loading

This has been changed in E3SM-Project/E3SM#6306

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar requested a review from irenavankova June 4, 2024 08:36
@xylar xylar self-assigned this Jun 4, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jun 4, 2024 •
edited
Loading

Testing

The ocean/isomip_plus/planar/2km/z-star/Ocean0 test case on Chrysalis with Intel and OpenMPI is BFB using this branch and the merge commit for E3SM-Project/E3SM#6306 as compared with a baseline from shortly before E3SM-Project/E3SM#6306. Without this change, results after E3SM-Project/E3SM#6306 were not BFB, as expected.

@xylar xylar removed the request for review from irenavankova June 4, 2024 09:03
@xylar xylar mentioned this pull request Jun 4, 2024
Merged
6 tasks
@xylar
Copy link
Collaborator Author

xylar commented Jun 4, 2024

Waiting on #827

@xylar xylar merged commit 2178234 into MPAS-Dev:main Jun 4, 2024
4 checks passed
@xylar xylar deleted the rename-tidal-velocity-namelist-option branch June 10, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
E3SM PR finished ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar