App::get_matches(): Fix buffer overrun

Replacement of d5767a7 based on suggestion in #2613. Co-authored-by: J-Donald Tournier <[email protected]>
MRtrix3 · May 10, 2023 · ebb35a5 · ebb35a5
1 parent 5489889
commit ebb35a5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/core/app.cpp b/core/app.cpp
@@ -128,7 +128,7 @@ namespace MR
       inline void get_matches (vector<const Option*>& candidates, const OptionGroup& group, const std::string& stub)
       {
         for (size_t i = 0; i < group.size(); ++i) {
-          if (stub.compare (0, stub.size(), group[i].id, stub.size()) == 0)
+          if (stub.compare (0, stub.size(), std::string(group[i].id)) == 0)
             candidates.push_back (&group[i]);
         }
       }