-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dicom fix XA10A parsing #2462
Dicom fix XA10A parsing #2462
Conversation
It works! With this warning:
but that is probably the whole point :) |
In my experience, XA30 is much cleaner than XA10. Hopefully, all XA10 systems have long since been upgraded. Therefore, the worst issues will be with archival datasets. This is timely, as Siemens is actively upgrading people from VE11 to XA30. My own center has deferred this upgrade. It would be great if users in the community to actively test tools and where possible provide sample datasets. As I recall, @josephmje @brainnetworklab and @lucijj were all instrumental in improving dcm2niix support, so perhaps they can also help with mrconvert. |
This was using XA31 |
Just a quick update: all my current DICOM tests pass with these changes. Full log below...
|
@jdtournier, would you like me to export the same data in Enhanced, Interoperability, and Mosaic mode? |
That might be instructive... But based on @neurolabusc's experience, I have a feeling the conclusion will be that it's essentially unusable. May be worth collating the data anyway so I can investigate when I have nothing better to do (probably when I retire, at this rate...). But if nothing else, it would be useful to double-check whether there have been any changes to their export that might actually make it possible to support the data (the example data I've been sent were collected a couple of years ago). |
@bjeurissen would it be possible to have share your data as a public validation dataset, similar to dcm_qa? Failing that, can you share the data directly with me? I worked closely with the Siemens engineers between the release of XA10 and XA20 to provide feedback on their images. However, I have never seen XA31 data. I do think it would be instructive to see all the data export types, to see how this information has evolved. However, beyond validation datasets, I strongly encourage XA users to only export to enhanced format. Historically, my experience is this:
|
8c0d0ee
to
9be560f
Compare
This is to allow parsing of Siemens XA10A "enhanced" DICOM format when saved in "Interoperability" mode. This results in all slices being given their own SeriesNumber, which predictably completely messes up sorting.
9be560f
to
130011e
Compare
@neurolabusc, thanks for sharing your experience - much appreciated. I'm not sure I agree with Siemens' description of their 'Interoperability' format though, feels like pretty much the opposite to me... 🤷♂️
👍 Otherwise, I've added a few more Vida datasets to my test suite, though they only cover XA10 & XA31 - no XA20. Still, it should increase coverage a bit... One thing I am concerned about is that the fix for these data is to essentially ignore the SeriesNumber if a SeriesInstanceUID (0020, 000E) is found within a RelatedSeriesSequence (0008, 1250) (in which case this is the more relevant link). In that case, we treat them as a single series. But there is always the possibility that some other perfectly acceptable data also makes reference to some other series, and that may interfere with the correct interpretation of the data. So far, all the testing checks out, but there is always the potential that this could impact on other data now or in the future... But for now, I'll merge anyway, and hope this doesn't break anything... 🤞 |
OK, first stab at sorting out DICOM parsing for borked Siemens XA10A data. For the full low-down on how much havoc Siemens have generated with this one, take a look through @neurolabusc's run-down of all the issues...
I'm currently running this PR through the full DICOM testing suite, see whether this introduces any regressions.
In the meantime, anyone with any Siemens enhanced data (not just XA10A) is encouraged to put this through its paces. If any issues, please let me know, and even better send me the data so I can reproduce and eventually add them to the testing suite.