tcksample: Ability to sample SH amplitudes #3028
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daljit46
reviewed
Oct 24, 2024
| if (interp.scanner (tck[i])) { | ||
| for (interp.index(3) = 0; interp.index(3) != interp.size(3); ++interp.index(3)) | ||
| sh_coeffs[interp.index(3)] = interp.value(); | ||
| const Eigen::Vector3f dir = (tck[(i == ssize_t(tck.size()-1)) ? i : (i+1)] - tck[i ? (i-1) : 0]).normalized(); |
There was a problem hiding this comment.
Perhaps std::clamp conveys the intention slightly better here? Something like:
const Eigen::Vector3f dir = (tck[std::clamp(i + 1, size_t(0), tck.size() - 1)] - tck[std::clamp(i - 1, size_t(0), tck.size() - 1)]).normalized();
Although for the second index, your current version is probably fine already.
There was a problem hiding this comment.
I will need to reprogram my brain to be accustomed to having that one available. However the base for this branch is pre-cmake and so pre-C++17.
(This particular calculation would also be better handled via #2189)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2942.
Restructure code to make better use of templating.
The input being a 4D SH should perhaps be a derived class, which instantiates the precomputer and has a local buffer for loading SH coefficients from the image.
Add test data and tests.