Show message to healer on healing a player, and the player who died that the killer got x points #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mrtechtroid
commented
Jun 17, 2024
•
mrtechtroid
commented
- This PR has been tested locally
- Based on suggestion Discord , shows a HUD message to even healer that he is has healed the player.
- Additionally based on suggestion Discord, shows a HUD message to player who died, that the killer got x points.
mrtechtroid
changed the title
|
LGTM. @mrtechtroid Next time, one change per PR please |
|
They were one line changes, it feels awkward to make such PR's |
For the record such PRs are my favorite :P |
Healing players should already show a score popup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.