test: introduce failing tests for invalid country codes.

MTES-MCT · Sep 19, 2024 · 6e3204b · 6e3204b
1 parent 262c8c0
commit 6e3204b
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 9 deletions.
diff --git a/src/Data/Textile/Query.elm b/src/Data/Textile/Query.elm
@@ -110,12 +110,6 @@ buildApiQuery clientUrl query =
 
 decode : Decoder Query
 decode =
-    let
-        -- Note: Using Json.Decode.Extra's optionalField here because we want
-        -- a failure when a Maybe decoded field value is invalid
-        strictOptional field decoder =
-            DE.andMap (DE.optionalField field decoder)
-    in
     Decode.succeed Query
         |> strictOptional "airTransportRatio" Split.decodeFloat
         |> strictOptional "business" Economics.decodeBusiness
@@ -143,13 +137,20 @@ decode =
         |> strictOptional "yarnSize" Unit.decodeYarnSize
 
 
+strictOptional : String -> Decoder a -> Decoder (Maybe a -> b) -> Decoder b
+strictOptional field decoder =
+    -- Note: Using Json.Decode.Extra's optionalField here because we want
+    -- a failure when a Maybe decoded field value is invalid
+    DE.andMap (DE.optionalField field decoder)
+
+
 decodeMaterialQuery : Decoder MaterialQuery
 decodeMaterialQuery =
     Decode.succeed MaterialQuery
-        |> Pipe.optional "country" (Decode.maybe Country.decodeCode) Nothing
+        |> strictOptional "country" Country.decodeCode
         |> Pipe.required "id" (Decode.map Material.Id Decode.string)
         |> Pipe.required "share" Split.decodeFloat
-        |> Pipe.optional "spinning" (Decode.maybe Spinning.decode) Nothing
+        |> strictOptional "spinning" Spinning.decode
 
 
 encode : Query -> Encode.Value

diff --git a/tests/Server/RouteTest.elm b/tests/Server/RouteTest.elm
@@ -233,7 +233,33 @@ textileEndpoints db =
                     }
                 )
             |> expectTextileSingleErrorContains "physicalDurability"
-            |> asTest "should reject invalid POST body"
+            |> asTest "should reject invalid physicalDurability"
+        , "/textile/simulator"
+            |> testEndpoint db
+                "POST"
+                (Query.encode
+                    { tShirtCotonFrance
+                        | countrySpinning = Just (Country.Code "invalid")
+                    }
+                )
+            |> expectTextileSingleErrorContains "materials"
+            |> asTest "should reject invalid spinning country"
+        , "/textile/simulator"
+            |> testEndpoint db
+                "POST"
+                (Query.encode
+                    { tShirtCotonFrance
+                        | materials =
+                            [ { country = Just (Country.Code "invalid")
+                              , id = Material.Id "ei-coton"
+                              , share = Split.full
+                              , spinning = Nothing
+                              }
+                            ]
+                    }
+                )
+            |> expectTextileSingleErrorContains "materials"
+            |> asTest "should reject invalid materials country"
         ]
     , describe "materials param checks"
         [ let