Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: turn food process category into a list #795

Merged
merged 15 commits into from
Oct 17, 2024
Merged

Conversation

ccomb
Copy link
Collaborator

@ccomb ccomb commented Oct 9, 2024

🔧 Problem

The food process category is unique, though a process can be used in different contexts.

🍰 Solution

This PR turns the category into a categories list.

🚨 Points to watch/comments

This PR is the first of a series to bring the data model of food, textile (and object) closer.

🏝️ How to test

run the usual tests

ecobalyse-private: food_process_categories

@ccomb ccomb changed the title Food process categories factor: Food process categories Oct 11, 2024
@ccomb ccomb changed the title factor: Food process categories refactor: Food process categories Oct 11, 2024
@ccomb ccomb changed the title refactor: Food process categories refactor: turn food process category into a list Oct 11, 2024
data/common/import_.py Show resolved Hide resolved
src/Data/Food/Process.elm Outdated Show resolved Hide resolved
Copy link
Member

@n1k0 n1k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unsure about the ordering change but I understand people have strong opinions and don't want to be a blocker here.

src/Data/Food/Process.elm Outdated Show resolved Hide resolved
src/Data/Food/Process.elm Outdated Show resolved Hide resolved
@ccomb ccomb merged commit 91c67a8 into master Oct 17, 2024
7 checks passed
@ccomb ccomb deleted the food_process_categories branch October 17, 2024 10:25
vjousse pushed a commit that referenced this pull request Nov 7, 2024
## [2.5.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.4.0..v2.5.0)
(2024-11-06)



### 🚀 Features

- Add bookmarks for objects
([#781](#781))
- Add object explorer pages.
([#803](#803))
- Distinguish Objects from Veli.
([#813](#813))
- Display score without durability
([#815](#815))
- Textile export
([#808](#808))
- Object export
([#812](#812))

### 🪲 Bug Fixes

- Create object encrypted file for versions
([#800](#800))
- Improve object simulator.
([#799](#799))
- Fix encoded display name field.
([#820](#820))

### 🚜 Refactor

- Aggregate in python
([#794](#794))
- Turn food process category into a list
([#795](#795))
- Aggregate in python
([#807](#807))

### ⚙️ Miscellaneous Tasks

- Upgrade dependencies to their latest version, Oct. 2024.
([#801](#801))
- Add tolerance to tests comparison
([#810](#810))
- *(data)* New export
([#819](#819))

### ◀️ Revert

- "refactor: aggregate in python"
([#806](#806))

<!-- generated by git-cliff -->

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants