-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: turn food process category into a list #795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccomb
changed the title
factor: Food process categories
refactor: Food process categories
Oct 11, 2024
ccomb
changed the title
refactor: Food process categories
refactor: turn food process category into a list
Oct 11, 2024
ccomb
force-pushed
the
food_process_categories
branch
from
October 11, 2024 07:53
846f145
to
f568d6f
Compare
vjousse
requested changes
Oct 14, 2024
ccomb
force-pushed
the
food_process_categories
branch
from
October 15, 2024 13:33
f3da8db
to
9da1f97
Compare
n1k0
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still unsure about the ordering change but I understand people have strong opinions and don't want to be a blocker here.
vjousse
requested changes
Oct 16, 2024
Co-authored-by: Nicolas Perriault <[email protected]>
ccomb
force-pushed
the
food_process_categories
branch
from
October 17, 2024 09:36
61cee56
to
a19ce12
Compare
vjousse
approved these changes
Oct 17, 2024
vjousse
pushed a commit
that referenced
this pull request
Nov 7, 2024
## [2.5.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.4.0..v2.5.0) (2024-11-06) ### 🚀 Features - Add bookmarks for objects ([#781](#781)) - Add object explorer pages. ([#803](#803)) - Distinguish Objects from Veli. ([#813](#813)) - Display score without durability ([#815](#815)) - Textile export ([#808](#808)) - Object export ([#812](#812)) ### 🪲 Bug Fixes - Create object encrypted file for versions ([#800](#800)) - Improve object simulator. ([#799](#799)) - Fix encoded display name field. ([#820](#820)) ### 🚜 Refactor - Aggregate in python ([#794](#794)) - Turn food process category into a list ([#795](#795)) - Aggregate in python ([#807](#807)) ### ⚙️ Miscellaneous Tasks - Upgrade dependencies to their latest version, Oct. 2024. ([#801](#801)) - Add tolerance to tests comparison ([#810](#810)) - *(data)* New export ([#819](#819)) ###◀️ Revert - "refactor: aggregate in python" ([#806](#806)) <!-- generated by git-cliff --> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
The food process category is unique, though a process can be used in different contexts.
🍰 Solution
This PR turns the category into a categories list.
🚨 Points to watch/comments
This PR is the first of a series to bring the data model of food, textile (and object) closer.
🏝️ How to test
run the usual tests
ecobalyse-private: food_process_categories