-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: object export #812
Merged
Merged
feat: object export #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦ into object-export
β¦alyse into agregate_in_python
β¦bject-export-ccomb
β¦bject-export-ccomb
paulboosz
changed the title
feat: Textile export merged on Object export
feat: object export
Nov 5, 2024
paulboosz
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm unsure which is the private branch, is it object-export or object-export-ccomb ? |
It seems to be the object-export-ccomb. Rerunning jobs and merging... |
vjousse
pushed a commit
that referenced
this pull request
Nov 7, 2024
## [2.5.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.4.0..v2.5.0) (2024-11-06) ### π Features - Add bookmarks for objects ([#781](#781)) - Add object explorer pages. ([#803](#803)) - Distinguish Objects from Veli. ([#813](#813)) - Display score without durability ([#815](#815)) - Textile export ([#808](#808)) - Object export ([#812](#812)) ### πͺ² Bug Fixes - Create object encrypted file for versions ([#800](#800)) - Improve object simulator. ([#799](#799)) - Fix encoded display name field. ([#820](#820)) ### π Refactor - Aggregate in python ([#794](#794)) - Turn food process category into a list ([#795](#795)) - Aggregate in python ([#807](#807)) ### βοΈ Miscellaneous Tasks - Upgrade dependencies to their latest version, Oct. 2024. ([#801](#801)) - Add tolerance to tests comparison ([#810](#810)) - *(data)* New export ([#819](#819)) ###βοΈ Revert - "refactor: aggregate in python" ([#806](#806)) <!-- generated by git-cliff --> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecobalyse-private: object-export-ccomb
π§ Problem
We copy/paste impacts for object domain -> no traceability
π° Solution
Compute and export impacts for object like we do for food
ποΈ How to test
in ecobalyse/data execute
make export_food
check that there isn't any diff
ecobalyse-private: object-export-ccomb