chore: filter sentry errors by env #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At least it works for sentry errors from node Can't test for the errors in the browser as there are CORS errors with the sentry hosted by beta. |
vjousse
force-pushed
the
fix/filter-sentry-err-by-env
branch
from
adea1b8
to
6dbf89c
Compare
vjousse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
Production and review app errors are mix and matched in Sentry.
Notion card
🍰 Solution
Use a different environment in Sentry for production and review-apps errors.
🚨 Points to watch / comments
I've introduced a new file
scalingo.jsonused to configure review apps https://doc.scalingo.com/platform/app/review-apps#run-a-task-after-each-deployment-of-a-review-appI have CORS issue with the envelope call on the review-app without knowing why. Could be a server config/version issue cf. getsentry/sentry#24637
🏝️ How to test
Clicking on the footer should throw an error (the code will be removed before merging).