Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix npm error when make_export_food #758

Merged
merged 2 commits into from
Sep 19, 2024
Merged

chore: fix npm error when make_export_food #758

merged 2 commits into from
Sep 19, 2024

Conversation

paulboosz
Copy link
Collaborator

@paulboosz paulboosz commented Sep 18, 2024 •
edited
Loading

Bug :
image

Fix :

  • The previous chown command in the Dockerfile is setting ownership to user ID 1000, but the error message suggests the container is running as user ID 1001. -> use the actual jovyan user ID in the container
  • clear the npm cache before running any npm commands

@paulboosz paulboosz marked this pull request as ready for review September 18, 2024 13:33
ccomb
ccomb approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@ccomb ccomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulboosz paulboosz merged commit 5ad9b8c into master Sep 19, 2024
8 checks passed
@paulboosz paulboosz deleted the chore/fix-docker-makefile branch September 19, 2024 07:32
n1k0 pushed a commit that referenced this pull request Sep 26, 2024
@paulboosz @n1k0
chore: fix npm error when make_export_food (#758)
170b083 
Bug : 

![image](https://github.com/user-attachments/assets/75098475-311d-4bf6-b88c-769e30f4dc90)

Fix :
- The previous chown command in the Dockerfile is setting ownership to
user ID 1000, but the error message suggests the container is running as
user ID 1001. -> use the actual jovyan user ID in the container
- clear the npm cache before running any npm commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccomb ccomb ccomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulboosz @ccomb