Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tableau de bord] endpoint de sauvegarde #1752

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

maximeperraultdev
Copy link
Collaborator

Related Pull Requests & Issues


  • Tests E2E (Cypress)

@@ -35,4 +35,7 @@ enum class BackendUsageErrorCode {

/** Thrown when an entity contain an unvalid property. */
UNVALID_PROPERTY,

/** Thrown when an entity could be saved. */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could not ?

val name: String,
val geom: Geometry,
val comments: String?,
val inseeCode: String?,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je pense que le code INSEE sera toujours présent, puisqu'on le récupère de l'api /extract, non?

Copy link
Collaborator Author

@maximeperraultdev maximeperraultdev Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu peux avoir un tableau qui pointe sur aucun département non ? SI on est loin des côtes ?

val name: String,
val geom: Geometry,
val comments: String?,
val inseeCode: String?,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem ici

return dashboardModel.toDashboardEntity()
}

private fun addRegulatoryAreas(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je me demande un truc mais je sais pas si c'est possible, y'a pas moyen de faire u fonction générique? pour éviter d'avoir toutes ses fonctions qui font la même chose

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne pense pas vu que je valorise pas le même attribut. Et je pense que la fonction générique serait assez compliqué ^^

Copy link
Collaborator

@claire2212 claire2212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le côté front tu pensais le faire dans une autre PR?
Pour moi dans le chiffrage y'avait le back, le front et la pop-up pour renommer le tableau de bord au premier enregistrement.

Je viens de regarder la vue liste, et je pense qu'il faut ajouter deux propriété à l'entité Dashboard: la date de création et la date de modification

@maximeperraultdev
Copy link
Collaborator Author

@claire2212 Oui je pensais la faire à part. et ok je vais ajouter les dates de création et date de modif 👍

@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/1749/save_dashboard branch 2 times, most recently from b150f78 to 0d93b6b Compare October 9, 2024 15:13
Copy link

sonarcloud bot commented Oct 10, 2024

@maximeperraultdev maximeperraultdev merged commit f34f31e into main Oct 14, 2024
24 checks passed
@maximeperraultdev maximeperraultdev deleted the maxime/feat/1749/save_dashboard branch October 14, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enregistrement du tableau de bord. ⏳: 13
3 participants