-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tableau de bord] endpoint de sauvegarde #1752
Conversation
backend/src/main/kotlin/fr/gouv/cacem/monitorenv/domain/entities/dashboard/DashboardEntity.kt
Outdated
Show resolved
Hide resolved
077d70c
to
da39e3f
Compare
da39e3f
to
a081a03
Compare
@@ -35,4 +35,7 @@ enum class BackendUsageErrorCode { | |||
|
|||
/** Thrown when an entity contain an unvalid property. */ | |||
UNVALID_PROPERTY, | |||
|
|||
/** Thrown when an entity could be saved. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could not
?
val name: String, | ||
val geom: Geometry, | ||
val comments: String?, | ||
val inseeCode: String?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je pense que le code INSEE sera toujours présent, puisqu'on le récupère de l'api /extract
, non?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tu peux avoir un tableau qui pointe sur aucun département non ? SI on est loin des côtes ?
val name: String, | ||
val geom: Geometry, | ||
val comments: String?, | ||
val inseeCode: String?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem ici
...tlin/fr/gouv/cacem/monitorenv/infrastructure/database/repositories/JpaDashboardRepository.kt
Outdated
Show resolved
Hide resolved
return dashboardModel.toDashboardEntity() | ||
} | ||
|
||
private fun addRegulatoryAreas( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je me demande un truc mais je sais pas si c'est possible, y'a pas moyen de faire u fonction générique? pour éviter d'avoir toutes ses fonctions qui font la même chose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je ne pense pas vu que je valorise pas le même attribut. Et je pense que la fonction générique serait assez compliqué ^^
...uv/cacem/monitorenv/infrastructure/database/repositories/interfaces/IDBBriefingRepository.kt
Outdated
Show resolved
Hide resolved
...fr/gouv/cacem/monitorenv/infrastructure/database/repositories/JpaDashboardRepositoryITest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le côté front tu pensais le faire dans une autre PR?
Pour moi dans le chiffrage y'avait le back, le front et la pop-up pour renommer le tableau de bord au premier enregistrement.
Je viens de regarder la vue liste, et je pense qu'il faut ajouter deux propriété à l'entité Dashboard
: la date de création et la date de modification
@claire2212 Oui je pensais la faire à part. et ok je vais ajouter les dates de création et date de modif 👍 |
b150f78
to
0d93b6b
Compare
0d93b6b
to
a1c9125
Compare
Quality Gate passedIssues Measures |
Related Pull Requests & Issues