Changes for Visual Studio compilation

[jerome-mixgenius]

These are some changes to make it possible to compile with Visual Studio:

• Move the definition of static variables in CPP files for tempo tap algorithms.
• Added missing include.
• Casting an unsigned int to int before making it negative.
• std::min and std::max couldn't be found. By writing (std::min) or (std::max), the symbols are found.
• Added ESSENTIA_API in front defintions for dllexport or dllimport. The macro was added only to declaration that were needed.

I tested and with these changes I was still able to compile on Mac OSX 10.11 with XCode 7.3, using the waf script. With these changes, I was able to compile Essentia on Windows 8.1 in Visual Studio 2013, with a custom solution.

[dbogdanov]

Thank you! As your contribution is larger than 20 lines of code can you submit a CLA form?

[jerome-mixgenius]

Hello,

As specified on the website, I sent a signed copy of the CLA to
[email protected]

Cheers,

Jerome Lavoie — Software Developer

a — #809 - 160 St. Viateur E.
Montréal, QC, Canada, H2T 1A8
m *— 438 883 0778
*w — landr.com

On Fri, Apr 22, 2016 at 1:23 PM, Dmitry Bogdanov [email protected]
wrote:

Thank you! As your contribution is larger than 20 lines of code can you
submit a CLA http://essentia.upf.edu/contribute form?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#396 (comment)

[carthach]

Nice work Jerome!

Question: are you compiling with dependencies (libav yaml etc) or is it just the minimal mode?

C

[jerome-mixgenius]

Hi,

I'm manually compiling the dependencies before Essentia.

The code I'm using essentia with already has dependencies on FFTW, FFMpeg
and taglib. So I only had to setup my Visual Studio project to link with
these.

• Yaml, with its cmake file, builds fine in Visual Studio 2013 using cmake
  . -G"Visual Studio 12 Win64"
  • - *I had to manually compile libsamplerate. It's quite easy since it only
    has 4 files.

Essentia itself is built with a Visual Studio 2013 solution that only
builds the files in src/essentia and src/algorithms.

Thank you,
Jerome Lavoie — Software Developer

a — #809 - 160 St. Viateur E.
Montréal, QC, Canada, H2T 1A8
m *— 438 883 0778
*w — landr.com

On Tue, May 10, 2016 at 5:52 PM, Cárthach Ó Nuanáin <
[email protected]> wrote:

Nice work Jerome!

Question: are you compiling with dependencies (libav yaml etc) or is it
just the minimal mode?

C

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#396 (comment)