Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unread comments status (new trial) #576

Closed
wants to merge 13 commits into from
Closed

Fix unread comments status (new trial) #576

wants to merge 13 commits into from

Commits on Dec 19, 2023

  1. Add cypress rules to ESLint & ignore some patterns

    @Splines
    Splines committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    8884707 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Allow usage of tempusDominus global variable

    @Splines
    Splines committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d1593f1 View commit details
    Browse the repository at this point in the history

  2. Ignore JS files with Sprocket syntax

    @Splines
    Splines committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    144135e View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Further improve rules, e.g. allow common globals

    @Splines
    Splines committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    19342f7 View commit details
    Browse the repository at this point in the history

  2. Ignore sprocket syntax in cable.js

    @Splines
    Splines committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    70dbfed View commit details
    Browse the repository at this point in the history

  3. Autofix all .js and .js.erb files 

    Command used:
`yarn run eslint --fix .`

Still 47 problems (27 errors, 20 warnings) after this.
    @Splines
    Splines committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    9b9c082 View commit details
    Browse the repository at this point in the history

  4. Fix variables in turbolink fix

    @Splines
    Splines committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    cedd0c4 View commit details
    Browse the repository at this point in the history

  5. Prepend unused variables with "_"

    @Splines
    Splines committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f8366ab View commit details
    Browse the repository at this point in the history

  6. Get rid of unused widget variable

    @Splines
    Splines committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    bc87b65 View commit details
    Browse the repository at this point in the history

  7. Fix specs comment tab alignment

    @Splines
    Splines committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    a8fc972 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Fix update issues with reader and media 

    See the discussion on #574 for the reasons behind this.
    @Splines
    Splines committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    9583efb View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Merge branch 'mampf-next' into fix/unread-comments-status-new-trial

    @Splines
    Splines committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c41141c View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Merge branch 'dev' into fix/unread-comments-status-new-trial

    @Splines
    Splines committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ae5f2a3 View commit details
    Browse the repository at this point in the history