Fix media statistics not showing #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to reflect the corresponding renaming of the route due to rubocop.
fosterfarrell9
approved these changes
Feb 12, 2024
Splines
added a commit
that referenced
this pull request
Feb 14, 2024
This is to reflect the corresponding renaming of the route due to rubocop.
fosterfarrell9
added a commit
that referenced
this pull request
Feb 16, 2024
* Warn about too long GitHub commit messages (#586) * Fix comment status (#585) * Reapply first fix for Reader/Media See discussion on #574 for further details. Previous PR for this was #576, closed in favor of this one as this directly branches off the new "dev" branch. * Correctly show latest post (might be current_user's comment) * Fix update of unread comments logic in comments controller * Fix update icon logic and latest post comment * Simplify latest comment logic * Improve code comments * Further improve comments * Fix wording in comment * Fix construction of media array & use `.blank?` instead of `.empty?` * Migrate `unread_comments` flag (fix inconsistencies) (#587) * Add dummy migration * Implement migration for unread comment flag * Remove unnecessary comment * Declare migration as not idempotent * Use array.length instead of counting * Throw error to prevent revert of migration * Fix severe flaws in unread comments migration * Simplify Reader retrieval * Use the more explicit `.nil?` method * Update migration date * Fix annoying bug: don't use `.select!` but `.select` * Polish migration e.g. update comment, more suitable name for the method etc. * Rename method according to #585 * Use `warn` log level for migration (#588) * Rename get_statistics.coffee file to statistics.coffee (#591) This is to reflect the corresponding renaming of the route due to rubocop. * fix behaviour of media search * Disable OR/AND buttons if "all" tags is enabled (inside the media search, right now only frontend change) * Use ids autogenerated by Rails This is such that we can still click on the label to select the respective radio button, instead of only being able to click on the radio button itself. * Disable AND/OR initially (until user deselects "all tags") * Don't restrict media search if "all" tags is enabled. If the "all tags" option is enabled in the search, we should allow the results to include *any* tag. This is automatically the case if we just don't add any restriction regarding the tag ids in the SOLR search. This change accompanies the frontend change to disable the AND/OR buttons if the "all" button is selected meaning the user wants to search for all tags. See #593 for more details. --------- Co-authored-by: Splines <[email protected]> Co-authored-by: Splines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #589. A silly bug introduced by myself not watching rubocop closely enough, see this change 🙈 It renamed the route from
get_statisticstostatisticsbut I forgot to rename the corresponding coffeescript file.