Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make preferences pane correctly resize #1109

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

rschiang
Copy link
Contributor

After some through study of the issue, I could track down the cause of collapsing preferences pane should be related to autoresizeSubviews. Interface Builder would warn about ambiguous constraints and AutoLayout stuff, but they are mostly red herrings (unless we ditch OS X 10.8 and switch to NSStackView, eliminating most of the painstaking constraints).

This should fix #1103.

@rschiang
Copy link
Contributor Author

This PR changes two things:

  • Set autoresizeSubviews="YES" (should be the default according to official doc).
  • Fix incorrect top padding value from 25 to 11.

I'm aware that autoresizeSubviews="NO" has been sitting in the codebase for a while. My judgement was that previously sloppy NSBox implementation ignored the property value, as problems only started emerging in last year.

The padding change is to fix the consistency of the top and bottom margin. I don't have a 10.8 system around, so I'm not sure if it breaks in the earlier version. Looks good on 10.14 though.

Copy link
Member

@FranklinYu FranklinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix with Xcode. LGRM.

@FranklinYu FranklinYu merged commit 4a80923 into MacDownApp:master Dec 8, 2019
@rschiang rschiang deleted the patch-pref branch April 8, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preferences trouble
3 participants