-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
3f01030
to
153d37e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
appveyor.yml
Outdated
|
||
|
||
# Install the build and runtime dependencies of the project. | ||
- "%CMD_IN_ENV% pip install --timeout=60 --trusted-host 28daf2247a33ed269873-7b1aad3fab3cc330e1fd9d109892382a.r6.cf2.rackcdn.com --find-links http://28daf2247a33ed269873-7b1aad3fab3cc330e1fd9d109892382a.r6.cf2.rackcdn.com/ numpy==1.11.3 scipy==0.18.1 smart_open pytest pytest-rerunfailures cython pyemd testfixtures scikit-learn Morfessor==2.0.2a4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use normal pip / pypi for these wheels? You'd need to start at scipy 1.0 but otherwise, as far as I know, you'd be alright.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we need to test with 0.18.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test that on travis / linux + OSX, and test scipy 1.0 on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do need these packages, probably better to use the https address : https://8003f898b26602186ccc-7b1aad3fab3cc330e1fd9d109892382a.ssl.cf2.rackcdn.com
# Upload the generated wheel package to Rackspace | ||
# On Windows, Apache Libcloud cannot find a standard CA cert bundle so we | ||
# disable the ssl checks. | ||
- "python -m wheelhouse_uploader upload --no-ssl-check --local-folder=. gensim-wheels" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add the container name - in this case (for a release) wheels
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But gensim-wheels
is container name, or I missed something?
appveyor.yml
Outdated
install: | ||
# Install Python (from the official .msi of http://python.org) and pip when | ||
# not already installed. | ||
- "powershell ./appveyor/install.ps1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you don't need this - Python should already be installed for the all versions you need.
Thanks @matthew-brett for the review! |
Right - I think |
Based on piskvorky/gensim#1731