Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

MNT Uses github actions for uploading to pypi #65

Closed
wants to merge 2 commits into from

Conversation

thomasjpfan
Copy link
Collaborator

This PR adds a github action so we can upload with pypi through the interface.

Screen Shot 2020-09-15 at 3 09 20 PM

  1. One needs to add the PYPI_TOKEN secret to enable uploading to pypi. (I already added a TEST_PYPI_TOKEN for testpypi).
  2. One has to type in pypi in the "Run workflow" UI to upload to pypi, otherwise it will upload to testpypi by default.
  3. There is a check_artifacts.py script that makes sure that wheelhouse_uploader fetches the correctly number of artifacts based on the azure-pipeline.yml configuration.

CC @ogrisel

@adrinjalali
Copy link
Collaborator

Do we now also fetch the sditst? I remember that was done manually

@thomasjpfan
Copy link
Collaborator Author

Do we now also fetch the sditst? I remember that was done manually

With ogrisel/wheelhouse-uploader#36 this also fetches the sdist, which is currently built in azure-pipelines.yml.

Here is an example for the output of the worflow, where you can see the sdist being downloaded. The overall workflow expectingly fails because testpypi already has the version 0.23.2 uploaded.

@ogrisel
Copy link
Contributor

ogrisel commented Nov 9, 2020

Now that we moved to build scikit-learn wheels directly in the main repo, this would have to be adapted to add it there instead:

https://github.com/scikit-learn/scikit-learn/blob/master/.github/workflows/wheels.yml

/cc @alfaro96

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants