#130 nested edge case #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marapper
force-pushed
the
master
branch
3 times, most recently
from
ea7d392
to
f879f4f
Compare
|
Seems reasonable and given that the tests pass, good enough for me ⏩ Sorry for the review delay 🙇 Thanks for the contribution! |
MadLittleMods
added a commit
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real edge case for #130 is comma-separated nested selectors inside another comma separated selectors, see example test.
Fix #130
Issue is about cloning nodes after traversing so lead to loosing links to cloned children nodes. My first approach is move cloning phase in tree traverse section (in hope that postcss walks to new nodes on next iteration) and it works fine.