-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add problems chain
and polygon
#5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @tmigot !
I only have a few suggestions, summarizing to:
- passing explicitly the arguments to the functions
- using the newest NLP backend in JuMP (ie replacing
@NLobjective
by@objective
and equivalently for@NLconstraint
). This is required to support ExaModels.
The docstrings look good to me. Maybe add a line to specify that these two models are taken from OptimizationProblems.jl
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
@frapac I added the includes in the main file :). As mentioned in the report, polygon has several local minima so it is hard to test the objective value there. |
@frapac I kept the existing docstring, but we should probably unify with the other problems, what do you think?