Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor files' structure in MadNLP #162

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Refactor files' structure in MadNLP #162

merged 3 commits into from
Mar 29, 2022

Conversation

frapac
Copy link
Collaborator

@frapac frapac commented Mar 28, 2022

This PR splits the file src/interiorpointsolver.jl in several files, all stored in a new folder src/IPM:

src/IPM/IPM.jl                                  # Definition of structure InteriorPointSolver   
src/IPM/callbacks.jl                            # Wrapper for NLPModels callbacks  
src/IPM/factorization.jl                        # Wrapper for linear solver
src/IPM/kernels.jl                              # IPM's kernels 
src/IPM/robust_restorer.jl                      # Robust restoration                                                    
src/IPM/solver.jl                               # IPM's solver                                              
src/IPM/utils.jl                                # some utilities for IPM

The goal is to ease the long term maintenance of the package.

@frapac frapac requested a review from sshin23 March 28, 2022 21:48
sshin23
sshin23 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@sshin23 sshin23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the changes. I'd call robust_restorer.jl simply restoration.jl

@frapac frapac merged commit 6d0f818 into master Mar 29, 2022
@frapac frapac deleted the fp/refactor branch March 29, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshin23 sshin23 sshin23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frapac @sshin23