-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper documentation to MadNLP #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @frapac! I love what you did in solver.md
and kkt.md
. I'll merge it right away after fixing the URL typo
docs/make.jl
Outdated
) | ||
|
||
deploydocs( | ||
repo = "github.com/exanauts/MadNLP.jl.git", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url should be github.com/MadNLP/MadNLP.jl.git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also in line 11
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
- Coverage 75.12% 74.93% -0.20%
==========================================
Files 38 38
Lines 3405 3351 -54
==========================================
- Hits 2558 2511 -47
+ Misses 847 840 -7
Continue to review full report at Codecov.
|
Thanks for the feedback @sshin23 ! |
First stab