Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages when invalid number is detected #226

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Improve error messages when invalid number is detected #226

merged 1 commit into from
Sep 28, 2022

Conversation

frapac
Copy link
Collaborator

@frapac frapac commented Sep 26, 2022

Solve #225

@frapac frapac requested a review from sshin23 September 26, 2022 14:59
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022 •
edited
Loading

Codecov Report

Merging #226 (b8bd591) into master (7c42a2f) will decrease coverage by 0.14%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   74.49%   74.34%   -0.15%     
==========================================
  Files          37       37              
  Lines        3674     3692      +18     
==========================================
+ Hits         2737     2745       +8     
- Misses        937      947      +10
Impacted Files Coverage Δ
src/IPM/solver.jl 91.39% <0.00%> (-1.92%) ⬇️
src/IPM/utils.jl 91.52% <ø> (ø)
src/IPM/callbacks.jl 100.00% <100.00%> (ø)
src/utils.jl 87.50% <0.00%> (+2.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sshin23
sshin23 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@sshin23 sshin23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frapac for working on this!

@frapac frapac merged commit 6ac071a into master Sep 28, 2022
@frapac frapac deleted the fp/invalid_number branch September 28, 2022 14:04
@frapac frapac mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshin23 sshin23 sshin23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frapac @codecov-commenter @sshin23