Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MOI interface #233

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Improve MOI interface #233

merged 3 commits into from
Oct 20, 2022

Conversation

sshin23
Copy link
Member

@sshin23 sshin23 commented Oct 19, 2022 •
edited
Loading

This PR

  • adds support for MOI.BarrierIterations
  • fixes the bug in set_optimizer_attribute

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022 •
edited
Loading

Codecov Report

Merging #233 (dd5253f) into master (6593459) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   74.22%   74.23%   +0.01%     
==========================================
  Files          38       38              
  Lines        3701     3703       +2     
==========================================
+ Hits         2747     2749       +2     
  Misses        954      954
Impacted Files Coverage Δ
src/Interfaces/MOI_interface.jl 71.46% <100.00%> (+0.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sshin23 sshin23 changed the title Add support for MOI.BarrierIterations Improve MOI interface Oct 19, 2022
frapac
frapac approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@frapac frapac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

src/Interfaces/MOI_interface.jl Show resolved Hide resolved
src/Interfaces/MOI_interface.jl Outdated Show resolved Hide resolved
@sshin23 sshin23 merged commit be4f87e into master Oct 20, 2022
@frapac frapac deleted the ss/barrier_iterations branch April 10, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frapac frapac frapac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sshin23 @codecov-commenter @frapac