Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LinearSolvers] Add support for LDL factorization in CHOLMOD #321

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

frapac
Copy link
Collaborator

@frapac frapac commented Apr 10, 2024

@frapac frapac requested a review from sshin23 April 10, 2024 12:26
Copy link
Member

@sshin23 sshin23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Have you observed any difference in performance?

@amontoison
Copy link
Contributor

amontoison commented Apr 10, 2024

I think that they they did a major upgrade of SuiteSparse between Julia 1.10 (SuiteSparse 7.0.4) and Julia 1.9 (SuiteSparse 5.1.0).
Do we want to support both version of SuiteSparse or just bump the compat entry of Julia?

@frapac
Copy link
Collaborator Author

frapac commented Apr 10, 2024

LGTM! Have you observed any difference in performance?

Currently running the benchmark on OPF instances ! Cholmod-LDL was slower than LDLFactorizations in my previous tests, but I was not using the correct inertia in MadNLP.

Do we want to support both version of SuiteSparse or just bump the compat entry of Julia?

Good point Alexis. I would suggest we support CHOLMOD-LDL only on Julia 1.10 then. What do you think would be best?

@amontoison
Copy link
Contributor

amontoison commented Apr 10, 2024

Yes, I think that it's best to simply add a check for VERSION ≥ v"1.10" and return an error that explicitly states that this linear solver is only supported with Julia 1.10 or higher (within MadNLP).

@sshin23
Copy link
Member

sshin23 commented Apr 11, 2024

Agreed with @amontoison's suggestion

@sshin23 sshin23 merged commit d270a61 into master Apr 26, 2024
7 checks passed
amontoison pushed a commit to amontoison/MadNLP.jl that referenced this pull request Jul 5, 2024
)

* [LinearSolvers] Add support for LDL factorization in CHOLMOD

* fix test for julia <= v1.9
@frapac frapac deleted the fp/cholmod branch July 23, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants