Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport MadNLP from MadNLP/libs #325

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Reexport MadNLP from MadNLP/libs #325

merged 4 commits into from
Apr 12, 2024

Conversation

sshin23
Copy link
Member

@sshin23 sshin23 commented Apr 12, 2024

With this change (approach taken in Makie), one can simply

using MadNLPGPU

instead of

using MadNLPGPU, MadNLP

Copy link
Collaborator

@frapac frapac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.81%. Comparing base (fcbbbda) to head (a200820).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   69.80%   69.81%           
=======================================
  Files          39       40    +1     
  Lines        3888     3889    +1     
=======================================
+ Hits         2714     2715    +1     
  Misses       1174     1174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sshin23 sshin23 merged commit 3737e62 into master Apr 12, 2024
5 of 6 checks passed
@sshin23 sshin23 deleted the ss/reexport branch April 12, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants