Skip to content

Commit

Permalink
fix: lint
Browse files Browse the repository at this point in the history
  • Loading branch information
MadaraUchiha-314 committed Nov 28, 2023
1 parent 78c6107 commit 8d5adbc
Show file tree
Hide file tree
Showing 3 changed files with 58 additions and 55 deletions.
15 changes: 6 additions & 9 deletions packages/rollup-plugin-module-federation/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@ import type {
ExportNamedDeclaration,
Node,
} from 'estree';
import type {
ModuleFederationPluginOptions,
SharedConfig,
} from '../types';
import type { ModuleFederationPluginOptions, SharedConfig } from '../types';
import type { SharedObject, ExposesObject } from './types';
import type { PackageJson } from 'type-fest';
import type { Plugin, ManualChunksOption, AcornNode } from 'rollup';
Expand Down Expand Up @@ -263,7 +260,7 @@ export default function federation(
...versionInfo,
version: resolvedModuleVersionInPkgJson,
requiredVersion: versionInLocalPkgJson ?? null,
...((shared)?.[moduleNameOrPath]),
...shared?.[moduleNameOrPath],
};
}
return versionInfo;
Expand Down Expand Up @@ -329,9 +326,9 @@ export default function federation(
...Object.entries(shared).map(
([sharedModuleName, sharedModuleHints]): FederatedModule => ({
name: sharedModuleName,
moduleNameOrPath: (sharedModuleHints)?.import
? ((sharedModuleHints).import)
: (sharedModuleName),
moduleNameOrPath: sharedModuleHints?.import
? sharedModuleHints.import
: sharedModuleName,
type: 'shared',
}),
),
Expand Down Expand Up @@ -478,7 +475,7 @@ export default function federation(
const importedModule = sharedModule.import ?? key;
if (importedModule) {
const versionForSharedModule =
getVersionForModule(importedModule);
getVersionForModule(importedModule);
if (sharedModule?.eager) {
return `
register(sharedScope, '${
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ export declare interface SharedObject {
*/
export declare interface ExposesObject {
[index: string]: ExposesConfig;
}
}
96 changes: 51 additions & 45 deletions packages/rollup-plugin-module-federation/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,52 +93,58 @@ export function getSharedConfig(shared: Shared): SharedObject {
}
}


export function getExposesConfig(exposes: Exposes): ExposesObject {
if (Array.isArray(exposes)) {
return exposes.reduce<ExposesObject>((exposedModules, exposedEntity): ExposesObject => {
if (typeof exposedEntity === 'string') {
return {
...exposedModules,
[exposedEntity]: {
import: exposedEntity,
},
};
} else if (typeof exposedEntity === 'object') {
return {
...exposedModules,
...getExposesConfig(exposedEntity),
};
} else {
throw Error(
'Could not parse item shared object[]. Item is: ',
exposedEntity,
);
}
}, {});
return exposes.reduce<ExposesObject>(
(exposedModules, exposedEntity): ExposesObject => {
if (typeof exposedEntity === 'string') {
return {
...exposedModules,
[exposedEntity]: {
import: exposedEntity,
},
};
} else if (typeof exposedEntity === 'object') {
return {
...exposedModules,
...getExposesConfig(exposedEntity),
};
} else {
throw Error(
'Could not parse item shared object[]. Item is: ',
exposedEntity,
);
}
},
{},
);
} else {
return Object.entries(exposes).reduce<ExposesObject>((exposedModules, [key, exposedEntity]): ExposesObject => {
if (typeof exposedEntity === 'string') {
return {
...exposedModules,
[key]: {
import: exposedEntity,
},
};
} else if (Array.isArray(exposedEntity)) {
throw Error('Specifying an array as an entrypoint for exposed modules is not supported yet');
}
else if (typeof exposedEntity === 'object') {
return {
...exposedModules,
[key]: exposedEntity,
};
} else {
throw Error(
'Could not parse item exposed object{}. Item is: ',
exposedEntity,
);
}
}, {});
return Object.entries(exposes).reduce<ExposesObject>(
(exposedModules, [key, exposedEntity]): ExposesObject => {
if (typeof exposedEntity === 'string') {
return {
...exposedModules,
[key]: {
import: exposedEntity,
},
};
} else if (Array.isArray(exposedEntity)) {
throw Error(
'Specifying an array as an entrypoint for exposed modules is not supported yet',
);
} else if (typeof exposedEntity === 'object') {
return {
...exposedModules,
[key]: exposedEntity,
};
} else {
throw Error(
'Could not parse item exposed object{}. Item is: ',
exposedEntity,
);
}
},
{},
);
}
}
}

0 comments on commit 8d5adbc

Please sign in to comment.