fix: adding sourcemaps #49 (#50)

* fix: adding sourcemaps #49 * fix: removing prettier
MadaraUchiha-314 · Apr 5, 2024 · c325da8 · c325da8
1 parent 847b685
commit c325da8
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 90 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/examples/project-a/package.json b/packages/examples/project-a/package.json
@@ -34,7 +34,6 @@
     "rollup": "3.23.0",
     "rollup-plugin-copy": "3.5.0",
     "rollup-plugin-module-federation": "*",
-    "rollup-plugin-prettier": "4.1.1",
     "webpack": "5.84.1",
     "webpack-cli": "5.1.1",
     "@rspack/cli": "0.5.9",

diff --git a/packages/examples/project-a/rollup.config.mjs b/packages/examples/project-a/rollup.config.mjs
@@ -3,7 +3,6 @@ import { nodeResolve } from '@rollup/plugin-node-resolve';
 import replace from '@rollup/plugin-replace';
 import copy from 'rollup-plugin-copy';
 import json from '@rollup/plugin-json';
-import prettier from 'rollup-plugin-prettier';
 
 import federation from 'rollup-plugin-module-federation';
 
@@ -13,6 +12,7 @@ const config = async ({ outputFormat }) => ({
   output: {
     dir: `dist/rollup/${outputFormat}`,
     format: outputFormat,
+    sourcemap: true,
   },
   plugins: [
     replace({
@@ -25,9 +25,6 @@ const config = async ({ outputFormat }) => ({
     }),
     json(),
     commonjs(),
-    prettier({
-      parser: 'babel',
-    }),
     copy({
       targets: [
         {

diff --git a/packages/examples/project-b/package.json b/packages/examples/project-b/package.json
@@ -28,7 +28,6 @@
     "rollup": "3.23.0",
     "rollup-plugin-copy": "3.5.0",
     "rollup-plugin-module-federation": "*",
-    "rollup-plugin-prettier": "4.1.1",
     "webpack": "5.84.1",
     "webpack-cli": "5.1.1",
     "@rspack/cli": "0.5.9",

diff --git a/packages/examples/project-b/rollup.config.mjs b/packages/examples/project-b/rollup.config.mjs
@@ -3,7 +3,6 @@ import { nodeResolve } from '@rollup/plugin-node-resolve';
 import replace from '@rollup/plugin-replace';
 import copy from 'rollup-plugin-copy';
 import json from '@rollup/plugin-json';
-import prettier from 'rollup-plugin-prettier';
 
 import federation from 'rollup-plugin-module-federation';
 
@@ -13,6 +12,7 @@ const config = ({ outputFormat }) => ({
   output: {
     dir: `dist/rollup/${outputFormat}`,
     format: outputFormat,
+    sourcemap: true,
   },
   plugins: [
     replace({
@@ -25,9 +25,6 @@ const config = ({ outputFormat }) => ({
     }),
     json(),
     commonjs(),
-    prettier({
-      parser: 'babel',
-    }),
     copy({
       targets: [
         {

diff --git a/packages/rollup-plugin-module-federation/src/index.ts b/packages/rollup-plugin-module-federation/src/index.ts
@@ -566,7 +566,10 @@ export default function federation(
         /**
          * TODO: We need human readable good code. Atleast until the terser plugin minifies it :p
          */
-        return remoteEntryCode.toString();
+        return {
+          code: remoteEntryCode.toString(),
+          map: remoteEntryCode.generateMap(),
+        };
       }
       return null;
     },
@@ -680,6 +683,7 @@ export default function federation(
         }
         return {
           code: magicString.toString(),
+          map: magicString.generateMap(),
         };
       },
     },