Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introducing vercel deployments #18 #20

Merged
merged 8 commits into from
Nov 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
185 changes: 184 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/examples/project-a/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
"rollup": "3.23.0",
"rollup-plugin-module-federation": "*",
"webpack": "5.84.1",
"webpack-cli": "5.1.1"
"webpack-cli": "5.1.1",
"rollup-plugin-copy": "3.5.0",
"copy-webpack-plugin": "11.0.0"
}
}
48 changes: 48 additions & 0 deletions packages/examples/project-a/public/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<html>
<head>
<title>Module Federation Experiments</title>
<script type="module">
const sharedScope = {
/**
* In the base-example, we have declared uuid as import: false
* So we provide a fallback by directly registering it with the shared scope object.
*/
uuid: {
'1.0.0': {
get: () => () => Promise.resolve({ v4: { mock: 'uuid' } }),
},
},
};

globalThis.sharedScope = sharedScope;

const basePath = window.location.href.slice(
0,
window.location.href.lastIndexOf('/'),
);
const remoteEntryUrl = `${basePath}/my-remote-entry.js`;
const container = await import(remoteEntryUrl);

console.log('doing container.init()');
await container.init(sharedScope);
console.log('shared scope: ', JSON.stringify(sharedScope, null, 2));

console.log("doing container.get('./react')");
const react = (await container.get('./react'))();
console.log('exposed module ./react: ', react);
console.log('shared scope: ', JSON.stringify(sharedScope, null, 2));

console.log("doing container.get('./index')");
const index = (await container.get('./index'))();
console.log('exposed module ./index', index);
</script>
</head>
<body>
<h3>View page source to see what's happening</h3>
<h3>Open JS console to see logs.</h3>
<h4>
Type globalThis.shareScope in the JS console to check the current state of
shared scope object.
</h4>
</body>
</html>
16 changes: 14 additions & 2 deletions packages/examples/project-a/rollup.config.mjs
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
import commonjs from '@rollup/plugin-commonjs';
import { nodeResolve } from '@rollup/plugin-node-resolve';
import replace from '@rollup/plugin-replace';
import { federationconfig } from './federation.config.js';
import copy from 'rollup-plugin-copy';

// import federation from '@originjs/vite-plugin-federation';
import federation from 'rollup-plugin-module-federation';

import { federationconfig } from './federation.config.js';

const outputDir = 'dist/rollup';

export default {
output: {
dir: 'dist/rollup',
dir: outputDir,
format: 'es',
},
plugins: [
Expand All @@ -19,5 +23,13 @@ export default {
federation(federationconfig),
nodeResolve(),
commonjs(),
copy({
targets: [
{
src: './public/index.html',
dest: outputDir,
},
],
}),
],
};
16 changes: 15 additions & 1 deletion packages/examples/project-a/webpack.config.mjs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import CopyPlugin from 'copy-webpack-plugin';
import ModuleFederationPlugin from 'webpack/lib/container/ModuleFederationPlugin.js';
import { federationconfig } from './federation.config.js';

Expand All @@ -18,5 +19,18 @@ export default {
experiments: {
outputModule: true,
},
plugins: [new ModuleFederationPlugin(federationconfig)],
plugins: [
new ModuleFederationPlugin({
...federationconfig,
/**
* Additional stuff for webpack.
*/
library: {
type: 'module',
},
}),
new CopyPlugin({
patterns: [{ from: 'public/index.html' }],
}),
],
};
4 changes: 2 additions & 2 deletions packages/rollup-plugin-module-federation/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ export default function federation(
const nearestPkgJson = getNearestPackageJson(resolvedModulePath);
const resolvedModuleVersionInPkgJson: string =
nearestPkgJson?.version ?? MODULE_VERSION_UNSPECIFIED;

if (Object.prototype.hasOwnProperty.call(shared, moduleNameOrPath)) {
const versionInLocalPkgJson = pkgJson?.dependencies?.[moduleNameOrPath];
return {
Expand Down Expand Up @@ -494,7 +494,7 @@ export default function federation(
.map(
([key, exposedModule]) => `
case '${key}': {
return import('${exposedModule}');
return import('${exposedModule}').then((module) => () => module);
}
`,
)
Expand Down
8 changes: 7 additions & 1 deletion packages/rollup-plugin-module-federation/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@ export function sanitizeModuleName(name: string): string {
return name.replace(/\.|\//g, '_');
}

export function getChunkNameForModule({ sanitizedModuleNameOrPath, type }: {sanitizedModuleNameOrPath: string, type: 'shared' | 'exposed'}) {
export function getChunkNameForModule({
sanitizedModuleNameOrPath,
type,
}: {
sanitizedModuleNameOrPath: string;
type: 'shared' | 'exposed';
}) {
return `__federated__${type}__${sanitizedModuleNameOrPath}`;
}

Expand Down
Loading